This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Clean up type system #439
Merged
Clean up type system #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
November 14, 2018 15:15
src/Analysis/Engine/Test/FluentAssertions/MemberContainerAssertionsExtensions.cs
Show resolved
Hide resolved
| @@ -942,19 +945,13 @@ class BankAccount(object): | |||
| var analysis = await server.OpenDefaultDocumentAndGetAnalysisAsync(code); | |||
|
|
|||
| var v0 = analysis.Should().HaveVariable("scanner").WithValueAt<IBuiltinInstanceInfo>(0); | |||
There was a problem hiding this comment.
you probably don't need this variable anymore.
jakebailey
reviewed
Nov 29, 2018
jakebailey
reviewed
Dec 4, 2018
added 2 commits
December 4, 2018 13:24
| @@ -141,7 +139,7 @@ public BuiltinInstanceInfo(BuiltinClassInfo klass) | |||
| public override IEnumerable<OverloadResult> Overloads { | |||
| get { | |||
| IAnalysisSet callRes; | |||
| if (_klass.GetAllMembers(ProjectState._defaultContext).TryGetValue("__call__", out callRes)) { | |||
| if (ClassInfo.GetAllMembers(ProjectState._defaultContext).TryGetValue("__call__", out callRes)) { | |||
There was a problem hiding this comment.
In TypeId, ClassInfo is checked for null, and here it isn't. Which one is correct?
There was a problem hiding this comment.
I checked ctor calls and I don't see how it can be null. And what would be the legal scenario for the null case...
added 5 commits
December 5, 2018 10:11
AlexanderSher
approved these changes
Dec 5, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Types hierarchy cleanup * Test fixes, part I * Restore IPythonBoundFunction * Fix function instance types * More fixes * Fix overload handling * Fix properties * Fix type factory * Remove class built-in type * Simplify builtins, remove obsolete method * Fix typeshed merge * Allow declaring module to be null * Correct assertion * Simplify functions/methods * Fix stub merge tests * Fix tests * Baselines * Null ref * Build break * Overrides signatures * Fix typeinfo tests * PR feedback * Better handle overloads * Build breaks * Baselines * PR fix * PR feedback * Merge conflict * Fix microsoft#446 * Fix microsoft#446
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
IPythonType=>IPythonFunction, make module a type, etc.IPythonClassAstPythonTypeWrapper.MemberIdis now function ofBuiltInTypeIdfor consistency.I will wait for #361 to go in first.