Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requiresMainQueueSetup to prevent warning and future side-effects #1035

Conversation

djalmaaraujo
Copy link
Contributor

New versions of react will require requiresMainQueueSetup method. Here's the warning:

Module CodePush requires main queue setup since it overrides `constantsToExport` but doesn't implement `requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

screenshot 2017-10-06 19 08 25

@max-mironov
Copy link
Contributor

@djalmaaraujo Thank you for contribution, looks good, merging it!

@max-mironov max-mironov merged commit 751bf02 into microsoft:master Oct 9, 2017
@djalmaaraujo djalmaaraujo deleted the react-warnings-requires-main-queue-setup branch October 10, 2017 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants