Add macOS tags

microsoft · Oct 21, 2023 · 0d0084c · 0d0084c
1 parent 123c61e
commit 0d0084c
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 6 deletions.
diff --git a/packages/react-native/React/CxxBridge/JSCExecutorFactory.h b/packages/react-native/React/CxxBridge/JSCExecutorFactory.h
@@ -17,9 +17,11 @@ class JSCExecutorFactory : public JSExecutorFactory {
   explicit JSCExecutorFactory(JSIExecutor::RuntimeInstaller runtimeInstaller)
       : runtimeInstaller_(std::move(runtimeInstaller)) {}
 
+  // [macOS
   void setEnableDebugger(bool enableDebugger);
 
   void setDebuggerName(const std::string &debuggerName);
+  // macOS]
 
   std::unique_ptr<JSExecutor> createJSExecutor(
       std::shared_ptr<ExecutorDelegate> delegate,
@@ -28,8 +30,10 @@ class JSCExecutorFactory : public JSExecutorFactory {
  private:
   JSIExecutor::RuntimeInstaller runtimeInstaller_;
 
+  // [macOS
   bool enableDebugger_ = true;
   std::string debuggerName_ = "JSC React Native";
+  // macOS]
 };
 
 } // namespace react

diff --git a/packages/react-native/React/CxxBridge/JSCExecutorFactory.mm b/packages/react-native/React/CxxBridge/JSCExecutorFactory.mm
@@ -14,23 +14,27 @@
 namespace facebook {
 namespace react {
 
+// [macOS
 void JSCExecutorFactory::setEnableDebugger(bool enableDebugger) {
   enableDebugger_ = enableDebugger;
 }
 
 void JSCExecutorFactory::setDebuggerName(const std::string &debuggerName) {
   debuggerName_ = debuggerName;
 }
+// macOS]
 
 std::unique_ptr<JSExecutor> JSCExecutorFactory::createJSExecutor(
     std::shared_ptr<ExecutorDelegate> delegate,
     std::shared_ptr<MessageQueueThread> __unused jsQueue)
 {
+  // [macOS
   facebook::jsc::runtimeConfig rc = {
     .enableDebugger = enableDebugger_,
     .debuggerName = debuggerName_,
   };
-  return std::make_unique<JSIExecutor>(facebook::jsc::makeJSCRuntime(std::move(rc)), delegate, JSIExecutor::defaultTimeoutInvoker, runtimeInstaller_);
+  // macOS]
+  return std::make_unique<JSIExecutor>(facebook::jsc::makeJSCRuntime(std::move(rc)), delegate, JSIExecutor::defaultTimeoutInvoker, runtimeInstaller_); // [macOS]
 }
 
 } // namespace react

diff --git a/packages/react-native/ReactCommon/cxxreact/JSExecutor.h b/packages/react-native/ReactCommon/cxxreact/JSExecutor.h
@@ -114,7 +114,7 @@ class RN_EXPORT JSExecutor {
   }
 
   /**
-   * Returns whether or not the underlying executor supports debugging.
+   * Returns whether or not the underlying executor supports debugging. // [macOS]
    */
   virtual bool isInspectable() {
     return false;

diff --git a/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp b/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp
@@ -36,8 +36,10 @@ class JSCRuntime : public jsi::Runtime {
  public:
   // Creates new context in new context group
   JSCRuntime();
+  // [macOS
   // Creates new context in new context group with config
   JSCRuntime(facebook::jsc::runtimeConfig &rc);
+  // macOS]
   // Retains ctx
   JSCRuntime(JSGlobalContextRef ctx);
   ~JSCRuntime();
@@ -394,6 +396,7 @@ JSCRuntime::JSCRuntime()
   JSGlobalContextRelease(ctx_);
 }
 
+// [macOS
 JSCRuntime::JSCRuntime(facebook::jsc::runtimeConfig &rc)
 	: JSCRuntime() {
 #ifdef _JSC_HAS_INSPECTABLE
@@ -404,6 +407,7 @@ JSCRuntime::JSCRuntime(facebook::jsc::runtimeConfig &rc)
   JSGlobalContextSetName(ctx_, JSStringCreateWithUTF8CString(rc.debuggerName.c_str()));
 
 }
+// macOS]
 
 JSCRuntime::JSCRuntime(JSGlobalContextRef ctx)
     : ctx_(JSGlobalContextRetain(ctx)),
@@ -494,11 +498,11 @@ std::string JSCRuntime::description() {
 }
 
 bool JSCRuntime::isInspectable() {
-#ifdef _JSC_HAS_INSPECTABLE
+#ifdef _JSC_HAS_INSPECTABLE // [macOS
   return JSGlobalContextIsInspectable(ctx_);
-#else 
+#else // macOS]
   return false;
-#endif
+#endif // [macOS]
 }
 
 namespace {
@@ -1584,9 +1588,11 @@ std::unique_ptr<jsi::Runtime> makeJSCRuntime() {
   return std::make_unique<JSCRuntime>();
 }
 
+// [macOS
 std::unique_ptr<jsi::Runtime> makeJSCRuntime(facebook::jsc::runtimeConfig rc) {
   return std::make_unique<JSCRuntime>(rc);
 }
+// macOS]
 
 } // namespace jsc
 } // namespace facebook
diff --git a/packages/react-native/ReactCommon/jsc/JSCRuntime.h b/packages/react-native/ReactCommon/jsc/JSCRuntime.h
@@ -13,14 +13,16 @@
 namespace facebook {
 namespace jsc {
 
+// [macOS
 struct runtimeConfig {
   bool enableDebugger;
   std::string debuggerName;
 };
+// macOS]
 
 std::unique_ptr<jsi::Runtime> makeJSCRuntime();
 
-std::unique_ptr<jsi::Runtime> makeJSCRuntime(facebook::jsc::runtimeConfig rc);
+std::unique_ptr<jsi::Runtime> makeJSCRuntime(facebook::jsc::runtimeConfig rc); // [macOS]
 
 } // namespace jsc
 } // namespace facebook