Skip to content

Commit

Permalink
Use C++17 namespace for compoments (facebook#41791)
Browse files Browse the repository at this point in the history 
Summary:
Pull Request resolved: facebook#41791

Same as facebook#41771 - but this time for compoments

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D51804740

fbshipit-source-id: 87f4db5dabfce4639f16fdcb1b1df0fee338a555
  • Loading branch information
@christophpurrer @pull
christophpurrer authored and pull[bot] committed Jan 17, 2024
1 parent a34a959 commit 4b163fe
Show file tree
Hide file tree
Showing 25 changed files with 792 additions and 1,584 deletions.
108 changes: 36 additions & 72 deletions ...-codegen/e2e/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using ArrayPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<ArrayPropsNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -45,13 +43,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using BooleanPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<BooleanPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -73,13 +69,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using ColorPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<ColorPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -101,13 +95,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using DimensionPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<DimensionPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -129,13 +121,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using EdgeInsetsPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EdgeInsetsPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -157,13 +147,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using EnumPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EnumPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -185,13 +173,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using EventNestedObjectPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EventNestedObjectPropsNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -213,13 +199,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using EventPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EventPropsNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -241,13 +225,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using FloatPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<FloatPropsNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -269,13 +251,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using ImagePropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<ImagePropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -297,13 +277,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using IntegerPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<IntegerPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -325,13 +303,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -353,13 +329,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using MixedPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<MixedPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -381,13 +355,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using MultiNativePropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<MultiNativePropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -409,13 +381,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using NoPropsNoEventsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<NoPropsNoEventsNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -437,13 +407,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using ObjectPropsNativeComponentComponentDescriptor = ConcreteComponentDescriptor<ObjectPropsNativeComponentShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -465,13 +433,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using PointPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<PointPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Expand All @@ -493,13 +459,11 @@ Object {
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
namespace facebook {
namespace react {
namespace facebook::react {
using StringPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<StringPropNativeComponentViewShadowNode>;
} // namespace react
} // namespace facebook
} // namespace facebook::react
",
}
`;
Loading

0 comments on commit 4b163fe

Please sign in to comment.