fix: Properly clean up RCTDevLoadingView on hide (#2201)

microsoft · Sep 26, 2024 · 704b60c · 704b60c
1 parent a87ddb5
commit 704b60c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/react-native/React/CoreModules/RCTDevLoadingView.mm b/packages/react-native/React/CoreModules/RCTDevLoadingView.mm
@@ -138,7 +138,7 @@ - (void)showMessage:(NSString *)message color:(RCTUIColor *)color backgroundColo
       self->_label.font = [UIFont monospacedDigitSystemFontOfSize:12.0 weight:UIFontWeightRegular];
       self->_label.textAlignment = NSTextAlignmentCenter;
 #else // [macOS
-      self->_window = [[NSWindow alloc] initWithContentRect:NSMakeRect(0, 0, 375, 20)
+      self->_window = [[NSPanel alloc] initWithContentRect:NSMakeRect(0, 0, 375, 20)
                                                  styleMask:NSWindowStyleMaskBorderless
                                                    backing:NSBackingStoreBuffered
                                                      defer:YES];
@@ -214,6 +214,8 @@ - (void)showMessage:(NSString *)message color:(RCTUIColor *)color backgroundColo
         }];
 #else // [macOS]
     [RCTKeyWindow() endSheet:self->_window];
+    self->_window = nil;
+    self->_hiding = false;
 #endif // macOS]
   });
 }