TextInput with multiline not triggering onChangeText callback in 0.71.2

[k1mmm]

Environment

react-native -v: 0.71.6
npm ls react-native-macos: 0.71.2

Steps to reproduce the bug

<TextInput multiline onChangeText={(text) => console.log(text)} />

Additional context

Works perfectly without 'multiline' prop

[Saadnajmi]

@shwanton FYI

[Saadnajmi]

It seems others have hit this too, and it seems pretty bad. We'll try to take a look at it and find a fix.

[k1mmm]

@Saadnajmi Awesome thanks! Can't wait to use 0.71, especially with that smooth content resizing =)

[shwanton]

Looks like TextInput onChangeText has issues w/ Paper on 0.71
facebook#36494

[k1mmm]

@shwanton this seem to be resolved now in the upstream repo
facebook@a804c0f

[Saadnajmi]

@shwanton this seem to be resolved now in the upstream repo
facebook@a804c0f

Looks like it should be picked for a future patch release, at which point we can merge it into our repo as well.
reactwg/react-native-releases#61 (reply in thread)

[k1mmm]

@Saadnajmi is there anyway we can confirm this will fix the issue before we wait around for the patch?

[Saadnajmi]

@k1mmm if you fork React Native macOS internally, you could try cherry picking the one commit.

Since RN 0.71.7 was just released, and 0.71.8 right now only has that one commit in it's pick requests, I'll consider just cherry-picking it along with all the 0.71.7 commits for React Native macOS. I'll update in this thread if we end up doing that.

[Saadnajmi]

I just tested cherry-picking that commit, and it doesn't seem to fix the issue :/
We'll have to keep debugging

[k1mmm]

@Saadnajmi Oh, that's unfortunate. Alright, thanks for the effort and the update!

[k1mmm]

@Saadnajmi Just wanna let you know onSubmitEditing do not work either on textInputs regarding being multiline or not

[Saadnajmi]

@k1mmm What key are you using got submit? And have you set the submitKeyEvents prop? For context, here's the logic:

react-native-macos/Libraries/Text/TextInput/RCTBaseTextInputView.m

Line 458 in 375c579

- (void)submitOnKeyDownIfNeeded:(NSEvent *)event

[shwanton]

facebook#33653 Changed this api and we need to update the RCTBackedTextFieldDelegateAdapter on macOS to use textInputShouldSubmitOnReturn instead.

Fix incoming.

[Saadnajmi]

Reopening till we backport to 0.71-stable

[k1mmm]

@k1mmm What key are you using got submit? And have you set the submitKeyEvents prop? For context, here's the logic:

react-native-macos/Libraries/Text/TextInput/RCTBaseTextInputView.m

Line 458 in 375c579

- (void)submitOnKeyDownIfNeeded:(NSEvent *)event

I'm using Enter key with nothing else, this used to work in 0.69 @Saadnajmi

[shwanton]

Fix was picked to 0.71-stable: #1812

[k1mmm]

Its working flawless now! Thanks allot!