Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text input not correctly submitting events #1811

Merged
merged 1 commit into from
May 4, 2023

Conversation

shwanton
Copy link

@shwanton shwanton commented May 4, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

https://github.com/facebook/react-native/blob/43bd29fb22b2b9993f68dc545bd1f84612e879ba/packages/react-native/Libraries/Text/TextInput/RCTBackedTextInputDelegate.h#L28

  • I also noticed that onChange was not being called correctly for MutliLine TextInput.
  • The reason was this change: 277129c
  • We overrode textInputDidChange but forgot to call [super textInputDidChange]

closes #1788

Changelog

[MACOS] [FIXED] - Fix TextInput to submit value to onChange & onSubmitEditing

Test Plan

SingleLine TextInput

CleanShot.2023-05-03.at.21.27.32.mp4

MultiLine TextInput

CleanShot.2023-05-03.at.21.25.34.mp4

NOTE: The double submit has been fixed here: facebook@a804c0f

@shwanton shwanton force-pushed the fix-multiline-submit-0.71 branch from 5fa3b8e to 88115f0 Compare May 4, 2023 04:31
@shwanton shwanton marked this pull request as ready for review May 4, 2023 04:32
@shwanton shwanton requested a review from a team as a code owner May 4, 2023 04:32
@Saadnajmi Saadnajmi merged commit 3de0462 into microsoft:main May 4, 2023
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request May 4, 2023
Saadnajmi pushed a commit that referenced this pull request May 4, 2023
…ing (#1811) (#1812)

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInput with multiline not triggering onChangeText callback in 0.71.2
2 participants