Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiColumn and SectionList test pages: clean up VirtualizedList in ScrollView errors #818

Closed
amgleitman opened this issue Aug 24, 2021 · 3 comments
Assignees
Labels
bug Something isn't working Stale

Comments

@amgleitman
Copy link
Member

Environment

(Working out of the main branch)

  1. node -v: 10.19.0
  2. yarn --version: 1.22.5
  3. xcodebuild -version: Xcode 12.4, Build version 12D4e

Steps to Reproduce

  1. Build and run RNTester on macOS
  2. Navigate to either the MultiColumn or SectionList test pages

Expected Behavior

No new errors or warnings pop up

Actual Behavior

The following warning occurs:

VirtualizedLists should never be nested inside plain ScrollViews with the same orientation because it can break windowing and other functionality - use another VirtualizedList-backed container instead.

Why is this important?

While not a showstopper in and of itself, it does prevent #816 from being able to fully bring in 646605b without causing Xcode unit tests to fail. This can interfere with our CI tests, so we should definitely fix this at some point.

@ghost ghost added the Needs: Triage 🔍 label Aug 24, 2021
amgleitman added a commit to amgleitman/react-native-macos that referenced this issue Aug 24, 2021
@HeyImChris HeyImChris added bug Something isn't working and removed Needs: Triage 🔍 labels Aug 26, 2021
@HeyImChris
Copy link

We'll need to fix up our test pages to not error/warning out. We should look upstream and see how they resolve the issue.

@github-actions
Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 27, 2022
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as completed Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants