Avoid RCTUnsafeExecuteOnMainQueueSync from RCTUIManager #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
reviewed
Jul 22, 2022
harrieshin
approved these changes
Jul 22, 2022
These calls are only needed for a temporary Fabric workaround and would result in a deadlock since we also call `RCTUnsafeExecuteOnUIManagerQueueSync` from the main thread during window resize. This is needed for now in Fabric only to call the temporary `componentViewName_DO_NOT_USE_THIS_IS_BROKEN` workaround on views, which we don't have on desktop since we're a way off from using Fabric (and hopefully this workaround will be gone then). It was originally added here facebook@ffc7ec9 At Meta we have disabled these lines since May 2021 to fix crashes in production.
christophpurrer
force-pushed
the
avoidRTCUnsafeExecuteOnMainQueueSync
branch
from
c9599c1
to
371ef59
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
These calls are only needed for a temporary Fabric workaround and would result in a deadlock since we also call
RCTUnsafeExecuteOnUIManagerQueueSyncfrom the main thread during window resize.This is needed for now in Fabric only to call the temporary
componentViewName_DO_NOT_USE_THIS_IS_BROKENworkaround on views, which we don't have on desktop since we're a way off from using Fabric (and hopefully this workaround will be gone then).It was originally added here facebook@ffc7ec9
At Meta we have disabled these lines since May 2021 to fix crashes in production.
Changelog
[macOS] [Fixed] - Avoid RCTUnsafeExecuteOnMainQueueSync from RCTUIManager
Test Plan
Ran rn-tester.
Crash no longer observed