Fix VoiceOver for single-line TextInput #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the appropriate override for AppKit (`setAccessibilityElement:`) so that the `NSTextField` will not get set to be accessible, since its cell instead is already accessible and performs the correct VoiceOver behaviors. VoiceOver now reads as you type in a single-line `TextInput`
christophpurrer
force-pushed
the
fixVoiceOverSingleLineText
branch
from
53d6365
to
4b5f4ba
Compare
harrieshin
approved these changes
Jul 22, 2022
chiuam
approved these changes
Jul 22, 2022
chiuam
pushed a commit
to chiuam/react-native-macos
that referenced
this pull request
Jul 25, 2022
This adds the appropriate override for AppKit (`setAccessibilityElement:`) so that the `NSTextField` will not get set to be accessible, since its cell instead is already accessible and performs the correct VoiceOver behaviors. VoiceOver now reads as you type in a single-line `TextInput` Co-authored-by: Scott Kyle <skyle@fb.com>
chiuam
pushed a commit
to chiuam/react-native-macos
that referenced
this pull request
Jul 25, 2022
This adds the appropriate override for AppKit (`setAccessibilityElement:`) so that the `NSTextField` will not get set to be accessible, since its cell instead is already accessible and performs the correct VoiceOver behaviors. VoiceOver now reads as you type in a single-line `TextInput` Co-authored-by: Scott Kyle <skyle@fb.com>
chiuam
added a commit
that referenced
this pull request
Jul 25, 2022
chiuam
added a commit
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This adds the appropriate override for AppKit (
setAccessibilityElement:) so that theNSTextFieldwill not get set to be accessible, since its cell instead is already accessible and performs the correct VoiceOver behaviors.VoiceOver now reads as you type in a single-line
TextInputChangelog
[macOS] [Fixed] - Fix VoiceOver for single-line TextInput
Test Plan
Focus field
Didn't announce the search field
Search...instead
You are currently on a text fieldwas shown
BEFORE
before.mov
AFTER
after.mov
Enter searchTerm
Didn't announce the search term
BEFORE
before2.mov
AFTER
after2.mov