Fix RCTImageCache on macOS #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
reviewed
Jul 22, 2022
The cache's `totalCostLimit` and the `_cacheStaleTimes` ivar were not getting set for Mac, presumably due to a merge mistake. I'm not sure what (if any) positive impact this will realistically have on memory consumption. Tested rn-tester scrolling through several threads with lots of images. Everything works well.
christophpurrer
force-pushed
the
imageCache
branch
from
1556e34
to
a7742fc
Compare
|
We did some investigating, and the original ifdef to not clear the cache on macOS seems to be because we only clear the cache for iOS specific notifications / concerns. That doesn't mean we can't have a limit on macOS, so this change seems good to merge :) |
Saadnajmi
approved these changes
Aug 9, 2022
4 tasks
|
Thanks for reviewing this one and for the detailed feedback |
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
The cache's `totalCostLimit` and the `_cacheStaleTimes` ivar were not getting set for Mac, presumably due to a merge mistake. I'm not sure what (if any) positive impact this will realistically have on memory consumption. Tested rn-tester scrolling through several threads with lots of images. Everything works well. Co-authored-by: Scott Kyle <skyle@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
The cache's `totalCostLimit` and the `_cacheStaleTimes` ivar were not getting set for Mac, presumably due to a merge mistake. I'm not sure what (if any) positive impact this will realistically have on memory consumption. Tested rn-tester scrolling through several threads with lots of images. Everything works well. Co-authored-by: Scott Kyle <skyle@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The cache's
totalCostLimitand the_cacheStaleTimesivar were not getting set for Mac, presumably due to a merge mistake. I'm not sure what (if any) positive impact this will realistically have on memory consumption.Changelog
[macOS] [Fixed] - Fix RCTImageCache on macOS
Test Plan
Tested rn-tester scrolling through several threads with lots of images. Everything works well.