Add undo/redo support for TextInput #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `allowsUndo = YES` and having the `NSTextView` delegate return a stable `NSUndoManager` mostly makes undo/redo work, but we also needed to register an undo action whenever the input contents was changed to something unexpected by JS. This also breaks undo coalescing in a couple key places to make the input behave naturally like other apps.
chiuam
approved these changes
Jul 22, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Setting `allowsUndo = YES` and having the `NSTextView` delegate return a stable `NSUndoManager` mostly makes undo/redo work, but we also needed to register an undo action whenever the input contents was changed to something unexpected by JS. This also breaks undo coalescing in a couple key places to make the input behave naturally like other apps. Co-authored-by: Scott Kyle <skyle@fb.com> # Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Setting `allowsUndo = YES` and having the `NSTextView` delegate return a stable `NSUndoManager` mostly makes undo/redo work, but we also needed to register an undo action whenever the input contents was changed to something unexpected by JS. This also breaks undo coalescing in a couple key places to make the input behave naturally like other apps. Co-authored-by: Scott Kyle <skyle@fb.com> # Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Setting
allowsUndo = YESand having theNSTextViewdelegate return a stableNSUndoManagermostly makes undo/redo work, but we also need to register an undo action whenever the input contents was changed to something unexpected by JS.This also breaks undo coalescing in a couple key places to make the input behave naturally like other apps.
Changelog
[macOS] [Added] - Add undo/redo support for TextInput
Test Plan
Before
Note: Bottom left corner casts key strokes from my keyboard
before.mov
After
after.mov