Don't send events when clicking on scrollbars #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ignore "touches" (clicks) on `NSScroller` such that JS does not process them resulting in a press event. Confirmed clicking scrollbar in rn-tester does not result in a click on the items underneath.
christophpurrer
force-pushed
the
dontSendScrollbarEvents
branch
from
6a366c8
to
639a631
Compare
Saadnajmi
approved these changes
Jul 26, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 30, 2023
This will ignore "touches" (clicks) on `NSScroller` such that JS does not process them resulting in a press event. Confirmed clicking scrollbar in rn-tester does not result in a click on the items underneath. Co-authored-by: Scott Kyle <skyle@fb.com>
Saadnajmi
added a commit
that referenced
this pull request
Jan 30, 2023
This will ignore "touches" (clicks) on `NSScroller` such that JS does not process them resulting in a press event. Confirmed clicking scrollbar in rn-tester does not result in a click on the items underneath. Co-authored-by: Christoph Purrer <christophpurrer@outlook.com> Co-authored-by: Scott Kyle <skyle@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
This will ignore "touches" (clicks) on `NSScroller` such that JS does not process them resulting in a press event. Confirmed clicking scrollbar in rn-tester does not result in a click on the items underneath. Co-authored-by: Scott Kyle <skyle@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
This will ignore "touches" (clicks) on `NSScroller` such that JS does not process them resulting in a press event. Confirmed clicking scrollbar in rn-tester does not result in a click on the items underneath. Co-authored-by: Scott Kyle <skyle@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This will ignore "touches" (clicks) on
NSScrollersuch that JS does not process them resulting in a press event.Changelog
[macOS] [Changed] - Don't send events when clicking on scrollbars
Test Plan
Confirmed clicking scrollbar in rn-tester does not result in a click on the items underneath.
Before
Both scrollView scroller and content clicks are processed
before.mov
After
Clicking onto the scrollView scroller > click is ignored
Clicking into the the scrollView > no change of behavior
after.mov