Fix event.locationX/Y to be in view's coordinate space #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue on macOS where the `locationX`/`Y` properties would incorrectly match `pageX`/`Y` unlike iOS (see lines 218/219 in the same file) and other platforms. Confirmed `locationX`/`Y` is now correctly reported in the view's coordinate space.
harrieshin
approved these changes
Jul 25, 2022
4 tasks
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
This fixes an issue on macOS where the `locationX`/`Y` properties would incorrectly match `pageX`/`Y` unlike iOS (see lines 218/219 in the same file) and other platforms. Confirmed `locationX`/`Y` is now correctly reported in the view's coordinate space. Co-authored-by: Scott Kyle <skyle@fb.com>
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 10, 2023
Summary: X-link: facebook/yoga#1288 Fixes facebook/yoga#1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Differential Revision: D45724864 fbshipit-source-id: 6a5ac596fd5862f53aa7256411f11bed3596f7da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This fixes an issue on macOS where the
locationX/Yproperties would incorrectly matchpageX/Yunlike iOS (see lines 218/219 in the same file) and other platforms.See #418
Changelog
[macOS] [Fixed] - Fix event.locationX/Y to be in view's coordinate space
Test Plan
Confirmed
locationX/Yis now correctly reported in the view's coordinate space.Before
After
