Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor enableFocusRing flag for multiline textFields #1301

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

christophpurrer
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This fixes a regression introduced in #1276
We should respect the boolean flag sent from JS to enable/disable the focusRing

Changelog

[macOS] [Fixed] - Honor enableFocusRing flag for multiline textFields

Test Plan

Used this example

  {
    title: 'Multiline true',
    render: function(): React.Node {
      return (
        <TextInput
          multiline={true}
          accessibilityLabel="I am the accessibility label for text input"
        />
      );
    },
  },
  {
    title: 'Multiline true, enableFocusRing true',
    render: function(): React.Node {
      return (
        <TextInput
          multiline={true}
          enableFocusRing={true}
          accessibilityLabel="I am the accessibility label for text input"
        />
      );
    },
  },    
  {
    title: 'Multiline true, enableFocusRing false',
    render: function(): React.Node {
      return (
        <TextInput
          multiline={true}
          enableFocusRing={false}
          accessibilityLabel="I am the accessibility label for text input"
        />
      );
    },
  }, 

Before

before.mov

After

after.mov

This fixes a regression introduced in microsoft#1276
We should respect the boolean flag sent from the JS to enable/disable the focusRing
@christophpurrer christophpurrer requested a review from a team as a code owner July 28, 2022 06:33
@chiuam chiuam merged commit 825d334 into microsoft:main Jul 28, 2022
chiuam pushed a commit to chiuam/react-native-macos that referenced this pull request Jul 28, 2022
chiuam pushed a commit to chiuam/react-native-macos that referenced this pull request Jul 28, 2022
chiuam pushed a commit to chiuam/react-native-macos that referenced this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants