Fix insertion point and placeholder placement for TextInput

[christophpurrer]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

This fixes issues where the insertion point (caret) would not initially render in the correct location for TextInput with padding. Also, for single-line inputs, the placeholder would also be in the wrong location.

Changelog

[macOS] [Fixed] - Fix insertion point and placeholder placement for TextInput

Test Plan

Set a padding of 10

    padding: 10,

Before

You must click to put the caret/insertionPointer in the correct location

before.mov

After

after.mov

[chiuam]

I think this change broke the auto-focus test case:

Untitled-1.mov

*** Assertion failure in -RCTTouchHandler _recordNewTouches:, /Users/amchiu/react-native-macos/React/Base/RCTTouchHandler.m:110
2022-08-08 21:00:41.054210-0400 RNTester-macOS[81288:6998379] [General] Touch is already recorded. This is a critical bug.

Maybe the logic in didMoveToWindow needs a second look?

[christophpurrer]

Thanks for pointing this out. That's indeed an issue. We don't have atm as we also changed RTCTouchHandler.
I think I need to wait on this change and see if I can upstream some of our changes to RTCTouchHandler

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

[Saadnajmi]

Don't close

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

[Saadnajmi]

Gonna stop marking these where they get stale...

[christophpurrer]

The latest iteration fixes the problem for the RCTTouchHandler by applying another band-aid solution.
However in the long term we need to find a better approach to correctly handle mouseUp events.
Maybe the

_shouldSendMouseUpOnSystemBehalf

BOOL approach is not the best one.

We have a large number RCTTouchHandler fixes - but also those are not yet in a state to upstream them ...

mouseUp1080.mov

[Saadnajmi]

@chiuam could you take a second look?