Refactor handling of keyDown/keyUp #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Aug 8, 2022
packages/rn-tester/js/examples/KeyboardEventsExample/KeyboardEventsExample.js
Show resolved
Hide resolved
Saadnajmi
approved these changes
Aug 9, 2022
|
Good to merge once build breaks are fixed! |
This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review)
christophpurrer
force-pushed
the
refactorKeyUpDownEventHandling
branch
from
2bf0b63
to
54d7a99
Compare
|
I was missing yet another |
Theoretically all this code could be ported to iOS easily one day 🤔 |
4 tasks
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 24, 2022
This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com>
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 24, 2022
This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com>
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 25, 2022
This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com>
4 tasks
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 25, 2022
This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com>
4 tasks
Saadnajmi
added a commit
that referenced
this pull request
Aug 25, 2022
…1374) * Refactor handling of keyDown/keyUp (#1338) This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com> * Deprecate onScrollKeyDown, refactor Flatlist selection logic (#1365) * Deprecate onScrollKeyDown remove pressable diff Remove JS handling for PageUp/Down, fix flow errors Add back "autoscroll to focused view" behavior remove commented code remove change to pressable Update documentation fix flow error fix lint issue Fix 'selectRowAtIndex' More simplification lock * Make method public again * Add initialSelectedIndex * macOS tags * fix lint * RNTester: only show the Flatlist keyboard navigation switch on macOS Co-authored-by: Christoph Purrer <christophpurrer@outlook.com> Co-authored-by: Scott Kyle <skyle@fb.com>
Saadnajmi
added a commit
that referenced
this pull request
Aug 26, 2022
…1375) * Revert "Revert Flatlist changes (#1306)" This reverts commit 8ce9545. * Refactor handling of keyDown/keyUp (#1338) This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com> * Deprecate onScrollKeyDown, refactor Flatlist selection logic (#1365) * Deprecate onScrollKeyDown remove pressable diff Remove JS handling for PageUp/Down, fix flow errors Add back "autoscroll to focused view" behavior remove commented code remove change to pressable Update documentation fix flow error fix lint issue Fix 'selectRowAtIndex' More simplification lock * Make method public again * Add initialSelectedIndex * macOS tags * fix lint * remove one more reference * yarn lint --fix * RNTester: only show the Flatlist keyboard navigation switch on macOS Co-authored-by: Christoph Purrer <christophpurrer@outlook.com> Co-authored-by: Scott Kyle <skyle@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com> # Conflicts: # React/Views/RCTViewKeyboardEvent.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
This refactors / simplifies certain keyUp|Down event handling. It will make a later change (adding textInput handling for textInput fields) easier (to review) Co-authored-by: Scott Kyle <skyle@fb.com> # Conflicts: # React/Views/RCTViewKeyboardEvent.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This refactors / simplifies certain keyUp|Down event handling.
It will make a later change (adding textInput handling for textInput fields) easier (to review)
Changelog
[macOS] [Changed] - Refactor handling of keyDown/keyUp
Test Plan
Note: The button example is not working ...
Before
Screen.Recording.2022-08-08.at.1.02.19.PM.mov
After
Screen.Recording.2022-08-08.at.1.49.21.PM.mov