Fix Appearance module to observe application appearance #1340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This fixes the
Appearance.getColorScheme()
API to return the application-level appearance instead of the last appearance of any root view, which breaks down in multi-window applications.In Messenger Desktop we always respect the OS appearance for main and setting windows, but force a darkTheme in the calling UI.
W/o this change returning from the calling UI would result in a wrong appearance setting on light theme OS setting.
Changelog
[macOS] [Fixed] - Fix Appearance module to observe application appearance
Test Plan
I have added this snippet to RNTester-macOS/ViewController.m
The macOS appearance was set to darkTheme.
(The test plan is not ideal as I don't have a valid multi-window setup, but it should suffice for a basic test)
Before
b1.mov
After
a.mov