Move RCTRootShadowView
creation to main thread
#1344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Solves the same problem that #733 was supposed to solve (originally backed out by 70ddf46).
We've seen a deadlock on iOS with two threads, one main and one background, making simultaneous calls to
+[RCTI18nUtil sharedInstance]
, with a background thread reaching the inside of thedispatch_once
block (as seen here) first. It appears that playing around withNSUserDefaults
on iOS (as done here) requires use of the main thread to "commit" changes to user defaults.The solution is to move the initialization of
RCTRootShadowView
, which depends on ourRCTI18n
singleton as per this line, to the main thread, and do everything else on the UIManager queue.This will later be brought upstream.
Changelog
[iOS] [Fixed] - Remove a deadlock involving
RCTI18nUtil
Test Plan
The deadlock no longer occurs on iOS, and macOS appears unaffected.