forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrollbar to multiline TextInput #1366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amgleitman
requested changes
Aug 22, 2022
amgleitman
approved these changes
Aug 22, 2022
@christophpurrer Do you expect any issues to your side with this change? If so, like |
I think @shwanton is the best person to answer that question. |
Opened #1368 as a followup |
chiuam
added a commit
to chiuam/react-native-macos
that referenced
this pull request
Aug 24, 2022
chiuam
added a commit
to chiuam/react-native-macos
that referenced
this pull request
Aug 24, 2022
chiuam
added a commit
to chiuam/react-native-macos
that referenced
this pull request
Aug 24, 2022
chiuam
added a commit
that referenced
this pull request
Aug 24, 2022
chiuam
added a commit
that referenced
this pull request
Aug 24, 2022
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Addresses #1364. This change adds scrollbar to multiline TextInput to indicate the text view is scrollable when possible.
Changelog
[Fixed] [macOS] - Add scrollbar to multiline TextInput
Test Plan
Before: No scrollbar when the text view is scrollable.
Before.mov
After: Scrollbar is shown after the text view becomes scrollable. (Note: Scrollbar remains visible if the text view is no longer scrollable.)
After.mov