Allow clients to override keyboard focus props on FlatList #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amgleitman
approved these changes
Aug 31, 2022
chiuam
approved these changes
Aug 31, 2022
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 31, 2022
…#1403) * Allow client to override keyboard focus props on Flatlist * typo * Update flow type
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 31, 2022
…#1403) * Allow client to override keyboard focus props on Flatlist * typo * Update flow type
This was referenced Aug 31, 2022
chiuam
pushed a commit
to chiuam/react-native-macos
that referenced
this pull request
Aug 31, 2022
…#1403) * Allow client to override keyboard focus props on Flatlist * typo * Update flow type
Saadnajmi
added a commit
that referenced
this pull request
Aug 31, 2022
Saadnajmi
added a commit
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
With
enableSelectionOnKeyPressset to true, I made the Flatlist by default focusable and show the focus ring. This matches the behavior of some NSTableViews in macOS, but not all. There are cases where the overall table is focusable and does not show a focus ring (showing the selected cells with a highlight instead) like in sidebars.Let's allow the user to override
focusableandenableFocusRingon Flatlist, so that they have more control over the UX. Turns out all this needed was moving{...props}afterkeyboardNavigationProps, so that the users passed in props could overwrite the defaults.Changelog
[macOS] [Fixed] - Allow clients to override keyboard focus props on FlatList
Test Plan
Added two switches to the test page to test the combos of props.
Screen.Recording.2022-08-30.at.6.29.16.PM.mov