Add option to enforce pasting plain text #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
force-pushed
the
pasteBoardTypes
branch
from
328f3c7
to
cb85f51
Compare
christophpurrer
commented
Sep 8, 2022
christophpurrer
commented
Sep 8, 2022
christophpurrer
force-pushed
the
pasteBoardTypes
branch
2 times, most recently
from
ffab1c5
to
d53b633
Compare
amgleitman
approved these changes
Sep 12, 2022
Saadnajmi
reviewed
Sep 12, 2022
Saadnajmi
reviewed
Sep 12, 2022
Saadnajmi
reviewed
Sep 12, 2022
Saadnajmi
reviewed
Sep 12, 2022
christophpurrer
force-pushed
the
pasteBoardTypes
branch
from
d53b633
to
4e46f21
Compare
Saadnajmi
reviewed
Sep 21, 2022
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
Saadnajmi
reviewed
Sep 21, 2022
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
christophpurrer
force-pushed
the
pasteBoardTypes
branch
from
4e46f21
to
a2c2390
Compare
|
Updated test case based on recent comments 720.mov |
christophpurrer
force-pushed
the
pasteBoardTypes
branch
from
a2c2390
to
f62f95f
Compare
Saadnajmi
approved these changes
Sep 21, 2022
Sure. Let's do this |
christophpurrer
force-pushed
the
pasteBoardTypes
branch
from
f62f95f
to
7eef5bc
Compare
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350
christophpurrer
force-pushed
the
pasteBoardTypes
branch
from
7eef5bc
to
df8cfbd
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 13, 2022
…edType property is used In microsoft#1429 I had naively assumed that `NSPasteboardTypeFileURL` is 1:1 replacement for the deprecated `NSFilenamesPboardType` property. It is not. It causes drag and drop of files from Finder to stop working.
Merged
4 tasks
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350 # Conflicts: # Libraries/Components/TextInput/TextInput.js
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…dTypes property is used In microsoft#1429 I had naively assumed that `NSPasteboardTypeFileURL` is 1:1 replacement for the deprecated `NSFilenamesPboardType` property. It is not. It causes drag and drop of files from Finder to stop working when a pastedTypes property is set.
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350 # Conflicts: # Libraries/Components/TextInput/TextInput.js
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…dTypes property is used In microsoft#1429 I had naively assumed that `NSPasteboardTypeFileURL` is 1:1 replacement for the deprecated `NSFilenamesPboardType` property. It is not. It causes drag and drop of files from Finder to stop working when a pastedTypes property is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types.
We want to ignore them in favor of plain text (NSPasteboardTypeString).
This change allows to opt into a custom list of supported paste types.
This is a follow-up to #1350
Changelog
[macOS] [Added] - Add option to enforce pasting plain text
Test Plan
No rich text formatting anymore
Screen.Recording.2022-09-08.at.3.30.01.PM.mov
Test case from #1350 still work
Screen.Recording.2022-09-08.at.3.30.29.PM.mov