-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to enforce pasting plain text #1429
Conversation
328f3c7
to
cb85f51
Compare
ffab1c5
to
d53b633
Compare
d53b633
to
4e46f21
Compare
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
4e46f21
to
a2c2390
Compare
Updated test case based on recent comments 720.mov |
a2c2390
to
f62f95f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Would reverse the order of the TextInputs in the example so that the one that can take images is closer to the image preview. Otherwise should be good after merge conflicts are resolved :)
Sure. Let's do this |
f62f95f
to
7eef5bc
Compare
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350
7eef5bc
to
df8cfbd
Compare
…edType property is used In microsoft#1429 I had naively assumed that `NSPasteboardTypeFileURL` is 1:1 replacement for the deprecated `NSFilenamesPboardType` property. It is not. It causes drag and drop of files from Finder to stop working.
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350 # Conflicts: # Libraries/Components/TextInput/TextInput.js
…dTypes property is used In microsoft#1429 I had naively assumed that `NSPasteboardTypeFileURL` is 1:1 replacement for the deprecated `NSFilenamesPboardType` property. It is not. It causes drag and drop of files from Finder to stop working when a pastedTypes property is set.
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types We want to ignore them in favor of plain text (NSPasteboardTypeString). This change allows to opt into a custom list of supported paste types. This is a follow-up to microsoft#1350 # Conflicts: # Libraries/Components/TextInput/TextInput.js
…dTypes property is used In microsoft#1429 I had naively assumed that `NSPasteboardTypeFileURL` is 1:1 replacement for the deprecated `NSFilenamesPboardType` property. It is not. It causes drag and drop of files from Finder to stop working when a pastedTypes property is set.
Please select one of the following
Summary
There are use cases in which we want to ignore the base class [NSTextView readablePasteboardTypes] return values, which mostly, include RTF and formatted URL types.
We want to ignore them in favor of plain text (NSPasteboardTypeString).
This change allows to opt into a custom list of supported paste types.
This is a follow-up to #1350
Changelog
[macOS] [Added] - Add option to enforce pasting plain text
Test Plan
No rich text formatting anymore
Screen.Recording.2022-09-08.at.3.30.01.PM.mov
Test case from #1350 still work
Screen.Recording.2022-09-08.at.3.30.29.PM.mov