Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.71] Remove TurbomoduleCxx-RNW/WinRT port #1765

Merged

Conversation

Saadnajmi
Copy link
Collaborator

Cherry pick of #1764 to 0.71-stable.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

We no longer need this, as React Native Core now has proper support for C++ turbomodules via the new RCT_NEW_ARCH_ENABLED flag

Changelog

[macOS] [Removed] - Remove TurbomoduleCxx-RNW/WinRT port

Test Plan

CI should pass

@Saadnajmi Saadnajmi requested a review from a team as a code owner March 22, 2023 22:24
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 22, 2023 22:24
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit bb7a4ea into microsoft:main Mar 31, 2023
@Saadnajmi Saadnajmi deleted the remove-winrt-71 branch March 31, 2023 04:31
@Saadnajmi
Copy link
Collaborator Author

This auto-merged to the wrong branch (main instead of 0.71-stable). No harm since I was going to do this in main anyway.. but yeah I'm not a fan of automerges being on by default :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants