forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publish.yml #1771
Merged
microsoft-github-policy-service
merged 5 commits into
microsoft:main
from
Saadnajmi:fix-publish
Apr 3, 2023
Merged
Fix publish.yml #1771
microsoft-github-policy-service
merged 5 commits into
microsoft:main
from
Saadnajmi:fix-publish
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
force-pushed
the
fix-publish
branch
8 times, most recently
from
March 31, 2023 23:04
f9cc96e
to
4157791
Compare
dannyvv
approved these changes
Apr 2, 2023
is it just really branch name changes? it does seem like nightly release now? |
harrieshin
reviewed
Apr 3, 2023
harrieshin
reviewed
Apr 3, 2023
harrieshin
approved these changes
Apr 3, 2023
This again merged while I still had a change I caught in PR that I wanted to fix... can we please disable automatic automerges? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
publish.yml
wasn't quite good in our last PR. Let's make some updates. Namely, let's fix all the steps that are conditional on branch names to use the right branch name (refs/head/main
instead of justmain
).The Intent is that on
main
we publish releases of typenightly
(AKA, a rollling release of the latest bits), and on*-stable
branches, we publish releases (I.E: 0.68.4, 0.71.0, etc...). The flow of what node scripts to call is slightly different betweennightly
andrelease
, and I try to control that via conditions on each Azure Pipeline step. Namely, release jobs need an extra call toprepare-package-for-release.js
.Note:
nightly
is not entirely accurate, since we publish every commit (acanary
), not every night. In practice, I don't think the label should matter.Changelog
[INTERNAL] [FIXED] - Fix publish.yml
Test Plan
I copied the publish job to
apple-pr.yml
and tested as much as I could. Unfortunately, it's not a perfect test, as I had to fudge some environment variables.