Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish.yml #1771

Merged

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Mar 31, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

publish.yml wasn't quite good in our last PR. Let's make some updates. Namely, let's fix all the steps that are conditional on branch names to use the right branch name (refs/head/main instead of just main).

The Intent is that on main we publish releases of type nightly (AKA, a rollling release of the latest bits), and on *-stable branches, we publish releases (I.E: 0.68.4, 0.71.0, etc...). The flow of what node scripts to call is slightly different between nightly and release, and I try to control that via conditions on each Azure Pipeline step. Namely, release jobs need an extra call to prepare-package-for-release.js.

Note: nightly is not entirely accurate, since we publish every commit (a canary), not every night. In practice, I don't think the label should matter.

Changelog

[INTERNAL] [FIXED] - Fix publish.yml

Test Plan

I copied the publish job to apple-pr.yml and tested as much as I could. Unfortunately, it's not a perfect test, as I had to fudge some environment variables.

@Saadnajmi Saadnajmi force-pushed the fix-publish branch 8 times, most recently from f9cc96e to 4157791 Compare March 31, 2023 23:04
@Saadnajmi Saadnajmi changed the title Test Fixes to publish.yml Mar 31, 2023
@Saadnajmi Saadnajmi marked this pull request as ready for review March 31, 2023 23:11
@Saadnajmi Saadnajmi requested a review from a team as a code owner March 31, 2023 23:11
@Saadnajmi Saadnajmi changed the title Fixes to publish.yml Fix publish.yml Mar 31, 2023
@harrieshin
Copy link

is it just really branch name changes? it does seem like nightly release now?

.ado/publish.yml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 372139b into microsoft:main Apr 3, 2023
@Saadnajmi
Copy link
Collaborator Author

This again merged while I still had a change I caught in PR that I wanted to fix... can we please disable automatic automerges?

@Saadnajmi Saadnajmi deleted the fix-publish branch April 3, 2023 18:13
@Saadnajmi Saadnajmi mentioned this pull request Apr 4, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants