Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish the SBOM back to Github #1785

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Our CI would generate the SBOM, and then commit all files and push back to Github as part of a version update. That meant the SBOM manifest was also picked up. Let's move the "Generate and Publish SBOM" steps to after the "Push back to Github" steps so they aren't picked up. Let's also remove the manifest files.

Changelog

[INTERNAL] [CHANGED] - Don't publish the SBOM back to Github

Test Plan

I'll keep an eye on the next publish.

@Saadnajmi Saadnajmi requested a review from a team as a code owner April 11, 2023 17:24
@Saadnajmi Saadnajmi changed the title Don't publish the SBOM Don't publish the SBOM back to Github Apr 11, 2023
@Saadnajmi Saadnajmi merged commit 535dd99 into microsoft:main Apr 11, 2023
@Saadnajmi Saadnajmi deleted the sbom branch April 11, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants