Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document releases flow #1789

Merged
merged 7 commits into from
Apr 24, 2023
Merged

Document releases flow #1789

merged 7 commits into from
Apr 24, 2023

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Update the Releases.md doc with actual info

Changelog

[GENERAL] [ADDED] - Update the Releases.md doc with actual info

Test Plan

N/A

@Saadnajmi Saadnajmi requested a review from a team as a code owner April 12, 2023 15:02
docs/Releases.md Outdated Show resolved Hide resolved
Copy link

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done some tweaks, and left some questions: I'm not sure I fully understand the process but it sounds like this process of releasing a new version gets triggered for every new commit that lands in a -stable branch?

We could use some clarity also around nightlies, are they actually working? Which branch do they get built from?

docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Show resolved Hide resolved
@lunaleaps
Copy link

lunaleaps commented Apr 18, 2023

Might be useful to have this diagram of core React Native release flows:
automated_release

@kelset
Copy link

kelset commented Apr 19, 2023

@lunaleaps: headsup - this is a PR for the macos repo about the macos release flow; I guess we need that release graph in some "release documentation flow" upstream for core too, but let's make sure to not confuse things ;)

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
@Saadnajmi
Copy link
Collaborator Author

done some tweaks, and left some questions: I'm not sure I fully understand the process but it sounds like this process of releasing a new version gets triggered for every new commit that lands in a -stable branch?

We could use some clarity also around nightlies, are they actually working? Which branch do they get built from?

Yes, releases get triggered for every new commit that lands on a stable branch. Nightlies are triggered for every new commit that lands on the main branch. Since that isn't actually a nightly (it doesn't happen once a night), the npm dist-tag is canary. And yes they are working.

@Saadnajmi
Copy link
Collaborator Author

@lunaleaps: headsup - this is a PR for the macos repo about the macos release flow; I guess we need that release graph in some "release documentation flow" upstream for core too, but let's make sure to not confuse things ;)

I'm going to elect to not include that graphic in the React Native macOS release doc, so as to not cause confusion. If that graphic is in the React Native repo / at a publicly accessible link, I can link it :)

@Saadnajmi
Copy link
Collaborator Author

done some tweaks, and left some questions: I'm not sure I fully understand the process but it sounds like this process of releasing a new version gets triggered for every new commit that lands in a -stable branch?

We could use some clarity also around nightlies, are they actually working? Which branch do they get built from?

I committed all your suggestions and added a few lines to the top clarifying the 3 types of builds we have and when they get released. I hope that helps clarify about nightlies.

docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
docs/Releases.md Outdated Show resolved Hide resolved
Copy link

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few more comments, overall it's almost ready to go I think.
A future improvement would be a section on "cutting a new minor" with details on how that should be handled.

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
@lunaleaps
Copy link

lunaleaps commented Apr 21, 2023

headsup - this is a PR for the macos repo about the macos release flow; I guess we need that release graph in some "release documentation flow" upstream for core too, but let's make sure to not confuse things ;)

Yup I'm aware! Was sharing the graph for context on the "Relevant scripts from React native core" section because there was some in-accuracies.

... We aren't synced to paste monorepo work just yet, so I will probably leave a note to say this changes for 0.72+.

The mono-repo doesn't actually change much of this flow. It's mostly scripts about bumping and publishing packages that aren't react-native and aren't private.

Getting this into react-native release docs

Agreed, we should add it!

@Saadnajmi Saadnajmi merged commit efb69d4 into microsoft:main Apr 24, 2023
@Saadnajmi Saadnajmi deleted the releases-doc branch August 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants