-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document releases flow #1789
Document releases flow #1789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done some tweaks, and left some questions: I'm not sure I fully understand the process but it sounds like this process of releasing a new version gets triggered for every new commit that lands in a -stable branch?
We could use some clarity also around nightlies, are they actually working? Which branch do they get built from?
@lunaleaps: headsup - this is a PR for the macos repo about the macos release flow; I guess we need that release graph in some "release documentation flow" upstream for core too, but let's make sure to not confuse things ;) |
Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
Yes, releases get triggered for every new commit that lands on a stable branch. Nightlies are triggered for every new commit that lands on the |
I'm going to elect to not include that graphic in the React Native macOS release doc, so as to not cause confusion. If that graphic is in the React Native repo / at a publicly accessible link, I can link it :) |
I committed all your suggestions and added a few lines to the top clarifying the 3 types of builds we have and when they get released. I hope that helps clarify about nightlies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few more comments, overall it's almost ready to go I think.
A future improvement would be a section on "cutting a new minor" with details on how that should be handled.
Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
Yup I'm aware! Was sharing the graph for context on the "Relevant scripts from React native core" section because there was some in-accuracies.
The mono-repo doesn't actually change much of this flow. It's mostly scripts about bumping and publishing packages that aren't
Agreed, we should add it! |
Please select one of the following
Summary
Update the Releases.md doc with actual info
Changelog
[GENERAL] [ADDED] - Update the Releases.md doc with actual info
Test Plan
N/A