[Fabric] Return active touch identifiers in surface touch handler on mouse up. #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
May 4, 2023
lenaic
added a commit
to lenaic/react-native-macos
that referenced
this pull request
Aug 7, 2023
…mouse up. (microsoft#1815) Co-authored-by: Nick <lefever@meta.com>
Saadnajmi
pushed a commit
that referenced
this pull request
Aug 7, 2023
* [Fabric] Return active touch identifiers in surface touch handler on mouse up. (#1815) Co-authored-by: Nick <lefever@meta.com> * [Fabric] Add mandatory color space conversion for macOS. (#1813) Co-authored-by: Nick <lefever@meta.com> * [Fabric] Clean up hit testing now that RCTUIView extends RCTPlatformView (#1814) * Clean up surface touch handler now that RCTUIView extends RCTPlatformView. * Fix the iOS build. --------- Co-authored-by: Nick <lefever@meta.com> * [Fabric] Use the layout metrics to get the scale factor in component views. (#1816) * Use the layout metrics to get the scale factor in component views. * Use layout metrics pointScaleFactor instead of RCTScreenScale on iOS. --------- Co-authored-by: Nick <lefever@meta.com> * Fix RNTester content not resizing with window. (#1818) Co-authored-by: Nick <lefever@meta.com> * Fix wrong text offset when a line height is set. (#1819) Co-authored-by: Nick <lefever@meta.com> * [Fabric] Fix scroll views hiding content underneath them in Fabric. (#1820) * Fix scroll views hiding content underneath them in Fabric. * Clean up Paper scroll view after shim scroll view fix. --------- Co-authored-by: Nick <lefever@meta.com> * [Fabric] Add support for image content mode and tint features (#1828) * Add RCTUIImageView to RCTUIKit to support iOS features on macOS. * Add support for tint and resize mode to Image on Fabric. * Clean up logging and add macOS tag. * Fix code style to match the style guide. --------- Co-authored-by: Nick <lefever@meta.com> * [Fabric] Fix text input rendering crashing by using layout metrics pixelScaleFactor (#1817) * Use layout metrics to assign the active scale factor to RCTUITextField. * Use layout metrics to assign the active scale factor to RCTUITextView. --------- Co-authored-by: Nick <lefever@meta.com> * [Fabric] Tint images using CIFilter fixing wrong tinted image size (#1843) * Tint images using CIFilter to fix wrong image size when enabling tinting. * Initialize the CIFilter input values with default values. --------- Co-authored-by: Nick <lefever@meta.com> --------- Co-authored-by: Nick <lefever@meta.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Apr 26, 2024
…andler on mouse up. (microsoft#1815) Summary: This stack picks all fabric changes merged on RN 0.71 macOS that have no side-effects on paper. Cherry-pick of Fabric fixes: microsoft#1815 Test Plan: Tested later in this stack. Reviewers: chpurrer, #rn-desktop Reviewed By: chpurrer Differential Revision: https://phabricator.intern.facebook.com/D48138672 Tasks: T158583598 # Conflicts: # packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Apr 26, 2024
…mouse up. (microsoft#1815) Summary: This stack picks all fabric changes merged on RN 0.71 macOS that have no side-effects on paper. Cherry-pick of Fabric fixes: microsoft#1815 Test Plan: Tested later in this stack. Reviewers: chpurrer, #rn-desktop Reviewed By: chpurrer Differential Revision: https://phabricator.intern.facebook.com/D48138672 Tasks: T158583598 # Conflicts: # packages/react-native/React/Fabric/RCTSurfacePointerHandler.mm
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Apr 28, 2024
…ch handler on mouse up. (microsoft#1815) Summary: This stack picks all fabric changes merged on RN 0.71 macOS that have no side-effects on paper. Cherry-pick of Fabric fixes: microsoft#1815 Test Plan: Tested later in this stack. Reviewers: chpurrer, #rn-desktop Reviewed By: chpurrer Differential Revision: https://phabricator.intern.facebook.com/D48138672 Tasks: T158583598 # Conflicts: # React/Fabric/RCTSurfaceTouchHandler.mm
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
May 2, 2024
…ch handler on mouse up. (microsoft#1815) Summary: This stack picks all fabric changes merged on RN 0.71 macOS that have no side-effects on paper. Cherry-pick of Fabric fixes: microsoft#1815 Test Plan: Tested later in this stack. Reviewers: chpurrer, #rn-desktop Reviewed By: chpurrer Differential Revision: https://phabricator.intern.facebook.com/D48138672 Tasks: T158583598 # Conflicts: # React/Fabric/RCTSurfaceTouchHandler.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
There are 11 active touch identifiers available in the surface touch handler. We were not returning identifiers when completing a touch on mouse up which led to the app hanging looking for a free touch identifier when all 11 slots were used up.
Changelog
[macOS] [FIXED] - App hanging after multiple clicks in fabric
Test Plan
Tested by running RNTester on macOS with fabric (
RCT_NEW_ARCH_ENABLED=1) and clicking around the app to check that the app doesn't hang anymore after a couple of click.Without the fix RNTester becomes unresponsive (the beachball at the end is not captured by the screen recording):
Screen.Recording.2023-05-04.at.17.23.15-1.mov
With the fix RNTester keeps working no matter how many times you click around:
Screen.Recording.2023-05-04.at.16.26.33-1.mov