Scrollview - fix text centered on render when centerContent is true #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Jun 1, 2023
shwanton
force-pushed
the
scrollview-fix-center-content
branch
from
4125cab
to
bc59c83
Compare
Saadnajmi
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Text centering with
centerContentprop only worked after content was first scrolled.https://reactnative.dev/docs/scrollview#centercontent-ios
With this change, the content is centered vertically/horizontally when rendered
Changelog
[MACOS] [FIXED] - Scrollview - fix text centered on render when centerContent is true
Test Plan
Before - Must scroll before content is centered
CleanShot.2023-05-31.at.18.48.07.mp4
After - Vertical
CleanShot.2023-05-31.at.18.44.26.mp4
After - Horizontal
CleanShot.2023-05-31.at.18.45.06.mp4