Fix ColorWithSystemEffect not returning the correct base color #1845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
When the colorWithSystemEffect object gets normalized, we should be calling @react-native/normalize-colors not processColor. This is a regression from 68 because in 68 we return the unprocessed color, not the noralized color object https://github.com/microsoft/react-native-macos/blob/0.68-stable/Libraries/StyleSheet/normalizeColor.js#L25
Changelog
Test Plan
Before:
After: