-[RCTAccessibilityManager announceForAccessibility:] calls into AppKit from background thread #1852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Specifically, NSAccessibilityPostNotificationWithUserInfo. Other methods such as
getCurrentHighContrastState
provide cached state (cached on main thread viaobserveValueForKeyPath
et al). Some other methods such assetAccessibilityFocus
dispatch to the main thread.Not doing so could lead to AppKit further firing selectors on UI logic in app code and lead to downstream issues.
Test Plan
I've verified that original badness I observed in Office that led to discovering this no longer reproduces. Announcement posts in Accessibility Inspector.