Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNTester] Add macOS dock icon #1875

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[RNTester] Add macOS dock icon #1875

merged 1 commit into from
Jul 11, 2023

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jul 8, 2023 •
edited
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

I finally found a tool to make Big Sur style dock icons :D. No more square app icon!

Changelog

[MACOS] [FIXED] - Add macOS style dock icons for RNTester-macOS

Test Plan

Pretty icons!
icon_128x128

Screenshot 2023-07-07 at 10 53 29 PM

@Saadnajmi Saadnajmi requested a review from a team as a code owner July 8, 2023 03:55
@Saadnajmi Saadnajmi merged commit 8b2bc73 into microsoft:main Jul 11, 2023
18 of 19 checks passed
@Saadnajmi Saadnajmi deleted the icon branch July 11, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amgleitman amgleitman amgleitman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saadnajmi @amgleitman