Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SocketRocket to 0.7.0 #1887

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Upgrade SocketRocket to 0.7.0 #1887

merged 4 commits into from
Jul 24, 2023

Conversation

amgleitman
Copy link
Member

@amgleitman amgleitman commented Jul 21, 2023 •
edited
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This upgrades the SocketRocket to 0.7.0, which fixes a number of retain cycle issues.

Changelog

[GENERAL] [FIXED] - Fix retain cycle issues in SocketRocket

Test Plan

Validated that the WebSocket test page still works.
If the CIs also pass, we should be good.

@amgleitman amgleitman requested a review from a team as a code owner July 21, 2023 01:10
Saadnajmi
Saadnajmi reviewed Jul 21, 2023
View reviewed changes
React-Core.podspec Outdated Show resolved Hide resolved
Saadnajmi
Saadnajmi approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also port to 0.71-stable and maybe make an upstream PR?

@amgleitman amgleitman mentioned this pull request Jul 21, 2023
Merged
4 tasks
@amgleitman
Copy link
Member Author

Can we also port to 0.71-stable and maybe make an upstream PR?

0.71-stable port is #1888, upstream PR will happen soon as well.

@amgleitman amgleitman merged commit ed995fb into microsoft:main Jul 24, 2023
16 of 17 checks passed
@amgleitman amgleitman deleted the socketrocket-0.7 branch July 24, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amgleitman @Saadnajmi