Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scope and path names for publish pipeline #1920

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

amgleitman
Copy link
Member

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This is a follow-up to #1919 and addresses three things:

  • Change some display names in our beachball publish pipeline so they line up with their newly generalized roles.
  • Remove packages/react-native from the beachball publish scope so we don't try to publish it from the main branch. (Note that the beachball publish pipeline only gets run from the main branch.)
  • Be explicit about the local file path that we publish react-native-macos from. (For some strange reason, npm was trying to interpret the original as a GitHub username and repository.)

Changelog

[INTERNAL] [FIXED] - More pipeline fixes

Test Plan

Running npm publish packages/react-native --dry-run locally results in this weird error:

npm ERR! code 128
npm ERR! An unknown git error occurred
npm ERR! command git --no-replace-objects ls-remote ssh://git@github.com/packages/react-native.git
npm ERR! git@github.com: Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.

Running npm publish ./packages/react-native --dry-run locally results in this, which is closer to what we want:

...
npm WARN This command requires you to be logged in to https://registry.npmjs.org/ (dry-run)
npm notice Publishing to https://registry.npmjs.org/ (dry-run)
...

@amgleitman amgleitman requested a review from a team as a code owner August 31, 2023 00:21
@amgleitman amgleitman merged commit c2195d9 into microsoft:main Aug 31, 2023
17 checks passed
@amgleitman amgleitman deleted the even-more-pipeline-fixes branch September 6, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants