Use Yarn 4 #2030
Merged
Use Yarn 4 #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may wait to see if facebook#42256 merges upstream first, so that we can pick the change up in a merge / cherry-pick it |
tido64
requested changes
Jan 12, 2024
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 22, 2024
Summary: Over in React Native macOS land, I opened microsoft#2030 to update our mono repo to use Yarn 4. As a side effect, all the `package.json` files are formatted as a side effect of running `yarn install`. So that React Native macOS doesn't maintain this diff (and because they should only be good / no harm), let's upstream the formatting changes. ## Changelog: [INTERNAL] [CHANGED] - Format package.json files in the monorepo Pull Request resolved: #42256 Test Plan: This change should be a no-op, CI should pass. Reviewed By: cortinico Differential Revision: D52727623 Pulled By: huntie fbshipit-source-id: 67862b16d576b0903abd91e016d7add4c19853dc
tido64
approved these changes
Jan 23, 2024
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary:
There's nothing preventing us from using yarn 4, and there are several long term benefits that could be had by being on the latest version of the package manager. Let's update! I ran the following steps:
yarn set version berrylocallylinker: "node-modules"in the.yarnrc.ymlfileyarnAn interesting side effect is that by running
yarnnow lints/formats all thepackage.jsonfiles in the mono repo. So that we don't maintain this extra diff, I'm opening facebook#42256 to upstream theses formats to React Native.Changelog:
[INTERNAL] [CHANGED] - Use Yarn 4 for the mono repo
Test Plan:
CI should pass. After all, running
yarnshould be the same.