Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Don't use iOS deployment target for macOS #2042

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jan 19, 2024

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

This PR aims to reduce the number of changes needed to add visionOS support, see: #2019

Fix two issues:

  1. Fix some typos where we were using the iOS deployment target for macOS, and had duplicated the definition of the min_supported_versions helper method (😵‍💫)
  2. Delete some stale pbxproj entries that don't do anything. These show up every now and then, and I didn't feel it was worth a separate PR to fix up.

Changelog:

[GENERAL] [FIXED] - Fix some typos and merge errors

Test Plan:

CI should pass.

@Saadnajmi Saadnajmi requested a review from a team as a code owner January 19, 2024 22:53
@Saadnajmi Saadnajmi changed the title fix: Don't use iOS deployment target for macOS fix(macOS): Don't use iOS deployment target for macOS Jan 19, 2024
@Saadnajmi Saadnajmi merged commit 4448130 into microsoft:main Jan 20, 2024
18 checks passed
@Saadnajmi Saadnajmi deleted the fix-typos branch January 20, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants