chore(cli): deprecate --configuration option in run-macos
#2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
force-pushed
the
feat/cli/depracate-flags-run-macos
branch
from
586d672
to
cc80c1e
Compare
szymonrybczak
force-pushed
the
feat/cli/depracate-flags-run-macos
branch
from
cc80c1e
to
aad358f
Compare
szymonrybczak
changed the title
--configuration and --project-path options in run-macos --configuration options in run-macos
szymonrybczak
changed the title
--configuration options in run-macos --configuration option in run-macos
tido64
reviewed
Jan 25, 2024
szymonrybczak
force-pushed
the
feat/cli/depracate-flags-run-macos
branch
from
c17ac0c
to
6e7669b
Compare
Saadnajmi
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary:
In future we would like to replace custom implementation of
run-macoswith the one that is inside createdcli-platform-apppackage inside https://github.com/react-native-community/cli. To unify implementations between all Apple's OOT platforms. To avoid creating many breaking changes I'm deprecating old options that are under different name in new implementation.Changelog:
[GENERAL] [DEPRECATED] - Deprecate
--configurationoption fromrun-macoscommand.Test Plan:
run-macos --configuration-> you should see the warning.run-macos --project-path-> you should also see the warning.