Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): deprecate --configuration option in run-macos #2054

Merged

Conversation

szymonrybczak
Copy link

@szymonrybczak szymonrybczak commented Jan 24, 2024

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

In future we would like to replace custom implementation of run-macos with the one that is inside created cli-platform-app package inside https://github.com/react-native-community/cli. To unify implementations between all Apple's OOT platforms. To avoid creating many breaking changes I'm deprecating old options that are under different name in new implementation.

Changelog:

[GENERAL] [DEPRECATED] - Deprecate --configuration option from run-macos command.

Test Plan:

  1. Setup CLI locally.
  2. Run run-macos --configuration -> you should see the warning.
  3. Run run-macos --project-path -> you should also see the warning.

@szymonrybczak szymonrybczak requested a review from a team as a code owner January 24, 2024 15:35
@szymonrybczak szymonrybczak force-pushed the feat/cli/depracate-flags-run-macos branch from 586d672 to cc80c1e Compare January 24, 2024 15:35
@szymonrybczak szymonrybczak marked this pull request as draft January 24, 2024 15:39
@szymonrybczak szymonrybczak force-pushed the feat/cli/depracate-flags-run-macos branch from cc80c1e to aad358f Compare January 25, 2024 11:41
@szymonrybczak szymonrybczak changed the title chore(cli): deprecate --configuration and --project-path options in run-macos chore(cli): deprecate --configuration options in run-macos Jan 25, 2024
@szymonrybczak szymonrybczak changed the title chore(cli): deprecate --configuration options in run-macos chore(cli): deprecate --configuration option in run-macos Jan 25, 2024
@szymonrybczak szymonrybczak marked this pull request as ready for review January 25, 2024 11:42
@szymonrybczak szymonrybczak force-pushed the feat/cli/depracate-flags-run-macos branch from c17ac0c to 6e7669b Compare February 5, 2024 08:32
@Saadnajmi Saadnajmi merged commit f1f50fe into microsoft:main Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants