Fix transform prop on View component
#2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Mar 22, 2024
Saadnajmi
reviewed
Mar 22, 2024
Saadnajmi
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2038.
We believe that the bug was introduced when this commit was merged in. This commit refactors how the transform prop is handled on the native side, but we didn't properly adapt it for macOS. We do that now.
Test Plan:
We added a
{skewX: '10deg'}transform to the "New App Screen Colors" section on the new app screen example in RNTester. The skew now appears correctly as it did under 0.72-stable.Also verified that animations involving transformations work as well.