Prevent spurious onBlur/onEndEditing events in <TextInput> elements with placeholder text
#2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is touching iOS code too, could we check if the problem reproes on iOS, and whether it can be usptreamed? If not, could we limit to macOS only blocks via ifdefs? I'm not sure we need to do that but it helps a little in merges. |
This doesn't repro on iOS because editing |
Saadnajmi
approved these changes
Aug 17, 2024
amgleitman
deleted the
avoid-text-did-end-editing-from-editing-placeholder
branch
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Aug 19, 2024
… with placeholder text (microsoft#2160) * Add _isUpdatingPlaceholderText to prevent spurious "did end editing" notifications * Organize macOS tags and ifdef blocks --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Aug 19, 2024
… with placeholder text (microsoft#2160) * Add _isUpdatingPlaceholderText to prevent spurious "did end editing" notifications * Organize macOS tags and ifdef blocks --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
amgleitman
added a commit
that referenced
this pull request
Aug 19, 2024
) * Deduplicate `textInputDid(Begin|End)Editing` calls for multiline `<TextInput>` elements (#2159) * Add _isCurrentlyEditing to RCTBaseTextInputView * Move _isCurrentlyEditing check earlier in textInputDidBeginEditing * Adjust comment * nit: remove extra newline * Limit changes to macOS --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com> * Prevent spurious onBlur/onEndEditing events in `<TextInput>` elements with placeholder text (#2160) * Add _isUpdatingPlaceholderText to prevent spurious "did end editing" notifications * Organize macOS tags and ifdef blocks --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com> --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
amgleitman
added a commit
that referenced
this pull request
Aug 19, 2024
) * Deduplicate `textInputDid(Begin|End)Editing` calls for multiline `<TextInput>` elements (#2159) * Add _isCurrentlyEditing to RCTBaseTextInputView * Move _isCurrentlyEditing check earlier in textInputDidBeginEditing * Adjust comment * nit: remove extra newline * Limit changes to macOS --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com> * Prevent spurious onBlur/onEndEditing events in `<TextInput>` elements with placeholder text (#2160) * Add _isUpdatingPlaceholderText to prevent spurious "did end editing" notifications * Organize macOS tags and ifdef blocks --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com> --------- Co-authored-by: Adam Gleitman <adgleitm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on #2159, I noticed that a single-line
<TextInput>with a placeholder causes spuriousonBlurandonEndEditingevents. For some strange reason, settingplaceholderAttributedStringon macOS causes theNSTextDelegateto calltextDidEndEditing. This PR blocks these events from reaching the JS side.Test Plan:
Validated in RNTester that
onBlurandonEndEditingdon't get called unexpectedly when dealing with a<TextInput>with placeholder text.