forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align cursor implementation to W3C cursors #2162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
force-pushed
the
cursor-extenstion
branch
from
August 14, 2024 06:36
c2bfb9f
to
720d855
Compare
Saadnajmi
changed the title
[Cherry-Pick] Align cursor implementation to W3C cursors
Align cursor implementation to W3C cursors
Aug 15, 2024
Saadnajmi
commented
Aug 15, 2024
packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
commented
Aug 15, 2024
tido64
reviewed
Aug 20, 2024
packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
Outdated
Show resolved
Hide resolved
packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
Show resolved
Hide resolved
tido64
approved these changes
Aug 20, 2024
dannyvv
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick facebook@d3e3e2a and extend the macOS implementation to help make the 0.75 merge easier.
Summary:
Some history:
0ef7992 Added cursor support to React Native macOS initially. facebook@73664f5 upstreamed a subset of that support (
auto
andpointer
) for iOS and visionOS. Then, facebook@d3e3e2a extended the cursor implementation in React Native Fabric to support all the web cursor values (so that out of trees platforms like windows and macOS could implement support). We are one of those out of tree platforms.. so let's implement the new cursor api. Since the cursor creation code is now much more complex, I refactored the paper and fabric implementation to be shared via a newRCTCursor.m
file that's an added diff to React Native macOS.Some notes:
disappearing-item
that was available from Appkit but not part of the web cursors. Additionally, We add support forvertical-text
which is missing from upstream.all-scroll
) we don't supportTest Plan:
Updated the test page with all the cursors.
Screen.Recording.2024-08-20.at.11.07.59.AM.mov