fix(animated): load NativeAnimatedModule on macOS #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
force-pushed
the
fix-event-emitter
branch
2 times, most recently
from
038ca1d to
eded80c
Compare
Saadnajmi
force-pushed
the
fix-event-emitter
branch
from
eded80c to
a38b36a
Compare
tido64
approved these changes
Dec 4, 2024
|
Oh, there's another one in Are you looking into it? |
We don't have Modal on macOS, so I skipped that one (there were a couple of iOS only checks). But maybe the code still runs so let me double check that. |
Saadnajmi
force-pushed
the
fix-event-emitter
branch
from
a38b36a to
30a80f6
Compare
Saadnajmi
changed the title
|
When can we expect this to be released? |
I need to backport to 0.76, but hopefully by Friday |
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Dec 12, 2024
Saadnajmi
added a commit
that referenced
this pull request
Dec 13, 2024
* fix(NativeEventEmitter): load NativeAnimatedModule on macOS (#2302) * update lock
|
@gabrieldonadel try this with RNM 0.76.6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves #2301
Test Plan:
CI should pass