Skip to content

Commit

Permalink
fix(android): bridgeless mode should be enabled by default on 0.74 (#…
Browse files Browse the repository at this point in the history
…2123)

When New Architecture is enabled on 0.74+, bridgeless mode should also
be enabled by default.
  • Loading branch information
tido64 committed Jul 16, 2024
1 parent 5308ac0 commit 33af66a
Showing 1 changed file with 15 additions and 8 deletions.
23 changes: 15 additions & 8 deletions android/test-app-util.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -275,17 +275,24 @@ ext.isBridgelessEnabled = { project, isNewArchEnabled ->
if (isNewArchEnabled) {
def bridgelessEnabled = project.findProperty("react.bridgelessEnabled")
?: project.findProperty("bridgelessEnabled")
if (bridgelessEnabled == "true") {
if (bridgelessEnabled != "false") {
def version = getPackageVersionNumber("react-native", project.rootDir)
def isSupported = version == 0 || version >= v(0, 73, 0)
if (!isSupported) {
logger.warn([
"WARNING: react-native 0.73 or greater is required for",
"Bridgeless Mode — disable `bridgelessEnabled` in your",
"`gradle.properties` or upgrade `react-native`"
].join(" "))

if (bridgelessEnabled == "true") {
if (!isSupported) {
logger.warn([
"WARNING: react-native 0.73 or greater is required for",
"Bridgeless Mode — disable `bridgelessEnabled` in your",
"`gradle.properties` or upgrade `react-native`"
].join(" "))
}
return isSupported
}
return isSupported

// https://github.com/facebook/react-native/commit/fe337f25be65b67dc3d8d99d26a61ffd26985dd8
def isEnabledByDefault = version == 0 || version >= v(0, 74, 0)
return isSupported && isEnabledByDefault
}
}
return false
Expand Down

0 comments on commit 33af66a

Please sign in to comment.