Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): bridgeless mode should be enabled by default on 0.74 #2123

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix(android): bridgeless mode should be enabled by default on 0.74 #2123

merged 1 commit into from
Jul 16, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 16, 2024

Description

When New Architecture is enabled on 0.74+, bridgeless mode should also be enabled by default.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.74
yarn
cd example
yarn android --extra-params "-PnewArchEnabled=true"

# In a separate terminal
yarn start

Verify that bridgeless is enabled.

@tido64
fix(android): bridgeless mode should be enabled by default on 0.74
32fb945 
When New Architecture is enabled on 0.74+, bridgeless mode should also
be enabled by default.
@tido64 tido64 requested a review from JasonVMo as a code owner July 16, 2024 06:32
@github-actions github-actions bot added the platform: Android This affects Android label Jul 16, 2024
@tido64 tido64 mentioned this pull request Jul 16, 2024
Closed
30 tasks
@tido64 tido64 merged commit 33af66a into trunk Jul 16, 2024
30 checks passed
@tido64 tido64 deleted the tido/android/fix-bridgeless branch July 16, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonVMo JasonVMo JasonVMo approved these changes

@Saadnajmi Saadnajmi Awaiting requested review from Saadnajmi

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @JasonVMo