Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix random Windows build failure #1235

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 30, 2022

Description

Windows builds randomly fail and may succeed if requeued: https://github.com/microsoft/react-native-test-app/actions/runs/3582401394/jobs/6026585132

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

# Make note of the original signature of `asEnum()`
cat node_modules/react-native-windows/Microsoft.ReactNative/Utils/Helpers.h

# Generate the VS solution (this can be run on Macs as well)
yarn install-windows-test-app --no-autolink

# Verify that the signature of `asEnum()` as been fixed
cat node_modules/react-native-windows/Microsoft.ReactNative/Utils/Helpers.h

CI should pass.

@github-actions github-actions bot added the platform: Windows This affects Windows label Nov 30, 2022
@tido64 tido64 requested review from kelset and afoxman November 30, 2022 12:43
@tido64 tido64 marked this pull request as ready for review November 30, 2022 12:44
@tido64 tido64 merged commit 4d94242 into trunk Nov 30, 2022
@tido64 tido64 deleted the tido/fix-random-windows-build-fail branch November 30, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants