Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: declare support for react-native 0.72 #1388

Merged
merged 4 commits into from
May 15, 2023
Merged

fix: declare support for react-native 0.72 #1388

merged 4 commits into from
May 15, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 13, 2023 •
edited
Loading

Description

Declare support for react-native/react-native-windows 0.72

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

For Android/iOS, run the test script:

scripts/test-matrix.sh 0.72

For Windows, run:

npm run set-react-version 0.72
cd example
yarn install-windows-test-app --use-nuget
yarn windows

Screenshots

Configuration Android iOS Windows
JSC n/a Simulator Screen Shot - iPhone SE (3rd generation) - 2023-05-15 at 11 14 18 image
Hermes Screenshot_1684141924 Simulator Screen Shot - iPhone SE (3rd generation) - 2023-05-15 at 11 17 44 n/a
Fabric n/a image n/a
Fabric + Hermes Screenshot_1684142402 image n/a

@tido64 tido64 linked an issue Apr 13, 2023 that may be closed by this pull request
Add support for react-native 0.72 #1359
Closed
8 tasks
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch from 6093e0a to df03358 Compare April 13, 2023 11:19
@github-actions github-actions bot added the platform: iOS This affects iOS label Apr 13, 2023
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch 5 times, most recently from 1cf89a8 to 025dc3c Compare April 13, 2023 13:30
@github-actions github-actions bot added the platform: Android This affects Android label Apr 13, 2023
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch 8 times, most recently from 398ed25 to 1764629 Compare April 16, 2023 10:49
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch from 1764629 to 2b37359 Compare April 21, 2023 11:45
@github-actions github-actions bot removed the platform: iOS This affects iOS label Apr 21, 2023
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch 5 times, most recently from d337af8 to c4fffd2 Compare April 24, 2023 11:25
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch from c4fffd2 to 4164d81 Compare May 4, 2023 08:00
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch from 4164d81 to 5a8653d Compare May 5, 2023 10:41
@tido64 tido64 marked this pull request as ready for review May 5, 2023 10:41
@tido64 tido64 requested a review from kelset May 5, 2023 10:42
@tido64 tido64 force-pushed the tido/support-rn-0.72 branch from 1136484 to ce56536 Compare May 9, 2023 08:17
@tido64 tido64 merged commit 53ab08d into trunk May 15, 2023
@tido64 tido64 deleted the tido/support-rn-0.72 branch May 15, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arazabishov arazabishov arazabishov approved these changes

@sweggersen sweggersen Awaiting requested review from sweggersen

@kelset kelset Awaiting requested review from kelset

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for react-native 0.72
2 participants
@tido64 @arazabishov