Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't require Plop to be installed separately #99

Merged
merged 1 commit into from
Jun 5, 2020
Merged

fix: Don't require Plop to be installed separately #99

merged 1 commit into from
Jun 5, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 4, 2020

No description provided.

@tido64 tido64 requested a review from alloy June 4, 2020 10:58
@tido64 tido64 self-assigned this Jun 4, 2020
@alloy
Copy link
Member

alloy commented Jun 4, 2020

Hmm, why use npx? I think that if you move plop in package.json to dependencies would be a better experience. That way the instructions would be:

yarn add react-native-test-app --dev
yarn plop --plopfile node_modules/react-native-test-app/plopfile.js --dest sample

@tido64
Copy link
Member Author

tido64 commented Jun 4, 2020

Aha, that's a good point. Didn't think of that.

@tido64 tido64 changed the title docs: Use npx to run Plop fix: Don't require Plop to be installed separately Jun 4, 2020
alloy
alloy reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@alloy alloy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove plop from the yarn add line (here https://github.com/microsoft/react-native-test-app/pull/99/files#diff-04c6e90faac2675aa89e2176d2eec7d8R36)

@alloy
Copy link
Member

alloy commented Jun 5, 2020

Great! 👍

@alloy alloy merged commit 9b41ea7 into master Jun 5, 2020
@alloy alloy deleted the tido/npx-plop branch June 5, 2020 12:49
github-actions bot pushed a commit that referenced this pull request Jun 5, 2020
@semantic-release-bot
chore(release): 0.0.16 [skip ci]
a2e0e47 
## [0.0.16](0.0.15...0.0.16) (2020-06-05)

### Bug Fixes

* Don't require Plop to be installed separately ([#99](#99)) ([9b41ea7](9b41ea7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alloy alloy alloy left review comments

Assignees

@tido64 tido64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @alloy