Skip to content

Commit

Permalink
Move winrt/Windows.Storage.h include out of USE_V8 conditional (#12259)
Browse files Browse the repository at this point in the history
* Move winrt/Windows.Storage.h include out of USE_V8 conditional

We now use the winrt/Windows.Storage.h header in the initialization of
Hermes (not just V8), so this header needs to be imported
unconditionally.

* Change files
  • Loading branch information
rozele committed Oct 18, 2023
1 parent d2ebb1a commit 66dc977
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Move winrt/Windows.Storage.h include out of USE_V8 conditional",
"packageName": "react-native-windows",
"email": "erozell@outlook.com",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion vnext/Microsoft.ReactNative/ReactHost/ReactInstanceWin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,9 @@
#include "BaseScriptStoreImpl.h"
#include "HermesRuntimeHolder.h"

#if defined(USE_V8)
#include <winrt/Windows.Storage.h>

#if defined(USE_V8)
#include "JSI/V8RuntimeHolder.h"
#endif // USE_V8

Expand Down

0 comments on commit 66dc977

Please sign in to comment.