Skip to content

Commit

Permalink
Fix code review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ZihanChen-MSFT committed Aug 8, 2023
1 parent fb03e8b commit 69f918a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ ${errors}`;
.replace(
/::_TYPE_DEFINITION_INCLUDE_::/g,
customTypesExist
? `#include "Native${preferredModuleName}Types.g.h"`
? `// #include "Native${preferredModuleName}Types.g.h" before this file to use the generated type definition`
: '',
)
.replace(/::_NAMESPACE_::/g, namespace);
Expand Down
2 changes: 1 addition & 1 deletion packages/sample-apps/codegen/NativeMyModuleSpec.g.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*/
#pragma once

#include "NativeMyModuleTypes.g.h"
// #include "NativeMyModuleTypes.g.h" before this file to use the generated type definition
#include <NativeModules.h>
#include <tuple>

Expand Down
1 change: 1 addition & 0 deletions packages/sample-apps/windows/SampleLibraryCPP/MyModule.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#pragma once

#include "..\..\codegen\NativeMyModuleTypes.g.h"
#include "..\..\codegen\NativeMyModuleSpec.g.h"
#include "DebugHelpers.h"

Expand Down

0 comments on commit 69f918a

Please sign in to comment.