Generate full debugging info in the pdbs (#2528)

* Generate full pdb's * FullProgramDatabaseFile should be DebugFull too
microsoft · May 24, 2019 · 93fc1cb · 93fc1cb
1 parent a2c5e41
commit 93fc1cb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/vnext/Desktop.DLL/React.Windows.Desktop.DLL.vcxproj b/vnext/Desktop.DLL/React.Windows.Desktop.DLL.vcxproj
@@ -82,7 +82,7 @@
       <PreprocessorDefinitions>_DEBUG;DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
     </ClCompile>
     <Link>
-      <GenerateDebugInformation>true</GenerateDebugInformation>
+      <GenerateDebugInformation>DebugFull</GenerateDebugInformation>
     </Link>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)'=='Release'">

diff --git a/vnext/Desktop/React.Windows.Desktop.vcxproj b/vnext/Desktop/React.Windows.Desktop.vcxproj
@@ -91,7 +91,7 @@
       <PreprocessorDefinitions>_DEBUG;DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
     </ClCompile>
     <Link>
-      <GenerateDebugInformation>true</GenerateDebugInformation>
+      <GenerateDebugInformation>DebugFull</GenerateDebugInformation>
     </Link>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)'=='Release'">

diff --git a/vnext/PropertySheets/DynamicLibrary/Release.props b/vnext/PropertySheets/DynamicLibrary/Release.props
@@ -16,7 +16,7 @@
     <Link>
       <EnableCOMDATFolding>true</EnableCOMDATFolding>
       <OptimizeReferences>true</OptimizeReferences>
-      <FullProgramDatabaseFile>true</FullProgramDatabaseFile>
+      <FullProgramDatabaseFile>DebugFull</FullProgramDatabaseFile>
     </Link>
   </ItemDefinitionGroup>
 

diff --git a/vnext/package.json b/vnext/package.json
@@ -18,17 +18,17 @@
     "watch": "node node_modules/@office-iss/sdx-build-tools/watch.js"
   },
   "disabledTasks": [
+    "api-doc",
     "copy",
-    "reka",
     "jest",
     "native-bundle:filtered",
-    "verify-ts-api",
-    "api-doc",
     "pack-nuget",
     "publish-nuget",
     "react-test",
+    "reka",
     "trickle",
     "ts:amd",
+    "verify-ts-api",
     "webpack"
   ],
   "rnpm": {