Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override of PerformanceApiExample.js #11373

Closed
TatianaKapos opened this issue Mar 14, 2023 · 1 comment · Fixed by #11423
Closed

Remove override of PerformanceApiExample.js #11373

TatianaKapos opened this issue Mar 14, 2023 · 1 comment · Fixed by #11423
Assignees
@TatianaKapos
Labels
bug Integration Follow-up Upstream
Milestone
Backlog

Comments

@TatianaKapos
Copy link
Contributor

Problem Description

Recent Integration creates an example in rn-tester that uses relative pathing instead of module pathing which cause us to override the file.

Fix is to make upstream PR and remove override in future integration.

Steps To Reproduce

  1. Set PerformanceApiExample.js to copy in override file

Expected Results

Playground should build fine

CLI version

npx react-native --version

Environment

System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
    Memory: 40.95 GB / 63.85 GB
  Binaries:
    Node: 16.12.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.1.0 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  Managers:
    RubyGems: Not Found
  SDKs:
    Android SDK: Not Found
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
      AllowAllTrustedApps: Enabled
      Versions: 10.0.17763.0, 10.0.18362.0, 10.0.19041.0, 10.0.22000.0
  IDEs:
    Android Studio: AI-213.7172.25.2113.9014738
    Visual Studio: 16.11.33328.57 (Visual Studio Enterprise 2019), 17.4.33403.182 (Visual Studio Enterprise 2022)
  Languages:
    Java: 11.0.16.1 - C:\Program Files\Eclipse Adoptium\jdk-11.0.16.101-hotspot\bin\javac.EXE
  npmPackages:
    @react-native-community/cli: Not Found
    react: Not Found
    react-native: Not Found
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Target Platform Version

10.0.19041

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

No response
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 14, 2023
@TatianaKapos TatianaKapos mentioned this issue Mar 14, 2023
Closed
@TatianaKapos TatianaKapos self-assigned this Mar 14, 2023
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Mar 15, 2023
@TatianaKapos @facebook-github-bot
Change PerformanceApiExample to use ModulePathing (#36478)
6a395cb 
Summary:
Recent integration from Windows brought in PerformanceApiExample that uses relative pathing to access react-native library. This causes us to have to override the file since our file structure is different. microsoft/react-native-windows#11373

This PR changes the example to use module pathing instead.

## Changelog

[GENERAL] [CHANGED] - Change PerformanceApiExample to use ModulePathing

Pull Request resolved: #36478

Test Plan: Tested and passed Windows tests

Reviewed By: rshest

Differential Revision: D44089501

Pulled By: javache

fbshipit-source-id: 99993a4f81556b4fef7c5d15af26b20df960ebf9
@chrisglein chrisglein added Upstream Integration Follow-up and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Mar 16, 2023
@chrisglein chrisglein added this to the Backlog milestone Mar 16, 2023
@chrisglein
Copy link
Member

PR is merged upstream. Need to take with the next integration.

@TatianaKapos TatianaKapos mentioned this issue Mar 28, 2023
Merged
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this issue May 22, 2023
@TatianaKapos @OlimpiaZurek
Change PerformanceApiExample to use ModulePathing (facebook#36478)
63ad13e 
Summary:
Recent integration from Windows brought in PerformanceApiExample that uses relative pathing to access react-native library. This causes us to have to override the file since our file structure is different. microsoft/react-native-windows#11373

This PR changes the example to use module pathing instead.

## Changelog

[GENERAL] [CHANGED] - Change PerformanceApiExample to use ModulePathing

Pull Request resolved: facebook#36478

Test Plan: Tested and passed Windows tests

Reviewed By: rshest

Differential Revision: D44089501

Pulled By: javache

fbshipit-source-id: 99993a4f81556b4fef7c5d15af26b20df960ebf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
bug Integration Follow-up Upstream
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Integrate RN Nightly Build 3/21/23 TatianaKapos/react-native-windows
2 participants
@chrisglein @TatianaKapos