Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name of all ViewGroups to ViewParent #132

Closed
rozele opened this issue Jan 22, 2016 · 0 comments
Closed

Change name of all ViewGroups to ViewParent #132

rozele opened this issue Jan 22, 2016 · 0 comments
Assignees
@rozele
Labels
Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Milestone
V1 Core

Comments

@rozele
Copy link
Collaborator

rozele commented Jan 22, 2016

ViewGroup is an implementation detail of Android. We don't have a specific base class in UWP for FrameworkElements that are also parent elements (although we have helper base classes for those that derive from Panel). We should use a generic name like ViewParent.
@rozele rozele self-assigned this Jan 22, 2016
@rozele rozele added this to the V1 Core milestone Jan 22, 2016
rozele added a commit that referenced this issue Jan 30, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
5732b79
@rozele rozele closed this as completed Feb 2, 2016
@rozele rozele removed the in progress label Feb 2, 2016
rozele added a commit that referenced this issue Feb 15, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
86ef666
rozele added a commit that referenced this issue Feb 21, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
3a5da83
rozele added a commit that referenced this issue Mar 1, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
e963ff0
rozele added a commit that referenced this issue Apr 21, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
f32c23d
rozele added a commit that referenced this issue May 17, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
928d72a
rozele added a commit that referenced this issue May 18, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
eb64fa1
rozele added a commit that referenced this issue May 25, 2016
@rozele
Fixes #132 - Cosmetic changes from ViewGroup -> ViewParent
ef673b4
GantMan pushed a commit to infinitered/react-native-windows that referenced this issue Sep 29, 2016
@rozele @GantMan
Fixes microsoft#132 - Cosmetic changes from ViewGroup -> ViewParent
f7bd63b
rozele pushed a commit that referenced this issue Jun 21, 2019
@woehrl01 @facebook-github-bot
Baseline support
c169a98 
Summary:
Added baseline support (see #132)

You have the ability for a custom baseline function (```float(*YGBaselineFunc)(YGNodeRef node);```) to return whatever baseline you want.
Closes facebook/yoga#317

Reviewed By: splhack

Differential Revision: D4385061

Pulled By: emilsjolander

fbshipit-source-id: cb8a59a09237c840fa3e21753ab68239997dab0c
@chiaramooney chiaramooney added the Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules. label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozele rozele

Labels
Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Projects
None yet
Milestone
V1 Core
Development

No branches or pull requests
2 participants
@rozele @chiaramooney